Re: [PATCH v3 1/2] dt-bindings: display: bridge: Add bindings for Chipone ICN6211

Hi Laurent,

On Mon, Feb 15, 2021 at 5:48 PM Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:

Hi Jagan,

Thank you for the patch.

On Sun, Feb 14, 2021 at 11:22:10PM +0530, Jagan Teki wrote:

...

ICN6211 is MIPI-DSI to RGB Convertor bridge from Chipone.

It has a flexible configuration of MIPI DSI signal input and produce RGB565, RGB666, RGB888 output format.

Add dt-bingings for it.

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

Changes for v3:

• updated to new dt-bindings style

.../display/bridge/chipone,icn6211.yaml | 90 +++++++++++++++++++ 1 file changed, 90 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml new file mode 100644 index 000000000000..13764f13fe46 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml @@ -0,0 +1,90 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/chipone,icn6211.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Chipone ICN6211 MIPI-DSI to RGB Converter bridge

+maintainers:

• • Jagan Teki jagan@amarulasolutions.com

+description: |

• ICN6211 is MIPI-DSI to RGB Convertor bridge from chipone.
• It has a flexible configuration of MIPI DSI signal input and
• produce RGB565, RGB666, RGB888 output format.

How does one select between the output formats ? Should the output connection option be described in the device tree ?

I think that is a good option to select output formats via dts. what if it makes it a generic property like data-lanes? since it is common across many other bridges.

...

+properties:

• compatible:
• enum:

•  - chipone,icn6211
  

• reg:
• maxItems: 1
• description: virtual channel number of a DSI peripheral
• reset-gpios:
• description: GPIO connected for the reset pin
• ports:
• $ref: /schemas/graph.yaml#/properties/ports
• properties:

•  port@0:
  

•    $ref: /schemas/graph.yaml#/properties/port
  

•    description:
  

•      Video port for MIPI DSI input
  

•  port@1:
  

•    $ref: /schemas/graph.yaml#/properties/port
  

•    description:
  

•      Video port for MIPI DPI output (panel or connector).
  

• required:

•  - port@0
  

•  - port@1
  

+required:

• • compatible
• • reg
• • reset-gpios
• • ports

How about regulators ?

Will add it in the next version.

Jagan.