Re: [PATCH 1/2] drm/msm/dpu: Remove impossible NULL check

On 10/22/2021 10:20 AM, Rob Clark wrote:

From: Rob Clark robdclark@chromium.org

Signed-off-by: Rob Clark robdclark@chromium.org

Reviewed-by: Jessica Zhang jesszhan@codeaurora.org

---

drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 5 ----- 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index e91568d4f09a..0ae397044310 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -187,11 +187,6 @@ static int dpu_crtc_get_crc(struct drm_crtc *crtc) int i = 0; int rc = 0;

• if (!crtc) {

• DPU_ERROR("Invalid crtc\n");
  

• return -EINVAL;
  

• }
• crtc_state = to_dpu_crtc_state(crtc->state); crcs = kcalloc(crtc_state->num_mixers, sizeof(*crcs), GFP_KERNEL);