Hi Sebastian.
On Sun, Aug 02, 2020 at 04:26:05PM +0200, Sebastian Reichel wrote:
Hi,
On Sun, Aug 02, 2020 at 01:06:35PM +0200, Sam Ravnborg wrote:
- Introduce backlight_{enable/disable)
- Use get/set methods for backlight_properties
- Drop redundant get_brightness() implementation The default implementation return the current brightness value
- Use macro for backlight initialization
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Tomi Valkeinen tomi.valkeinen@ti.com Cc: Sebastian Reichel sebastian.reichel@collabora.com Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Zheng Bin zhengbin13@huawei.com Cc: Sam Ravnborg sam@ravnborg.org
.../gpu/drm/omapdrm/displays/panel-dsi-cm.c | 35 ++++--------------- 1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c index 3484b5d4a91c..433e240896b3 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c @@ -110,15 +110,10 @@ static void dsicm_bl_power(struct panel_drv_data *ddata, bool enable) else return;
- if (enable) {
backlight->props.fb_blank = FB_BLANK_UNBLANK;backlight->props.state = ~(BL_CORE_FBBLANK | BL_CORE_SUSPENDED);backlight->props.power = FB_BLANK_UNBLANK;- } else {
backlight->props.fb_blank = FB_BLANK_NORMAL;backlight->props.power = FB_BLANK_POWERDOWN;backlight->props.state |= BL_CORE_FBBLANK | BL_CORE_SUSPENDED;- }
if (enable)
backlight_enable(backlight);else
backlight_disable(backlight);backlight_update_status(backlight);
backlight_update_status() is already called by backlight_enable/disable.
Right, thanks. Dropped in v2.
Let me know if you already have a similar patch and if I shall drop this.
It would be nice to have the panel parts of omapdrm migrated in this cycle. I recall you have 50+ patches pending.
Sam