Re: [Intel-gfx] [PATCH] drm/edid: Adding common CVT inferred modes when monitor allows range limited ones trough EDID.

At Wed, 11 Apr 2012 21:59:28 -0300, Rodrigo Vivi wrote:

There are many bugs open on fd.o regarding missing modes that are supported on Windows and other closed source drivers.

...

From EDID spec we can (might?) infer modes using GTF and CVT when monitor allows it trough range limited flag... obviously limiting by the range. From our code:

• EDID spec says modes should be preferred in this order:
• • preferred detailed mode
• • other detailed modes from base block
• • detailed modes from extension blocks
• • CVT 3-byte code modes
• • standard timing codes
• • established timing codes
• • modes inferred from GTF or CVT range information
• We get this pretty much right.

Not actually so right... We were inferring just using GTF... not CVT or even GTF2. This patch not just add some common cvt modes but also allows some modes been inferred when using gtf2 as well.

I tested the patch but it doesn't detect the desired resolutions such as 1600x900 or 1366x768, unfortunately.

Also, about the patch:

+static const struct drm_display_mode drm_cvt_inferred_modes[] = {

• /* 640x480@60Hz */
• { DRM_MODE("640x480", DRM_MODE_TYPE_DRIVER, 23750 640, 664,

A missing comma here.

•    720, 800, 0, 480, 483, 487, 500, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 800x600@60Hz */
• { DRM_MODE("800x600", DRM_MODE_TYPE_DRIVER, 38250, 800, 832,

•    912, 1024, 0, 600, 603, 607, 624, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 900x600@60Hz */
• { DRM_MODE("900x600", DRM_MODE_TYPE_DRIVER, 45250, 960, 992,

•    1088, 1216, 0, 600, 603, 609, 624, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1024x576@60Hz */
• { DRM_MODE("1024x576", DRM_MODE_TYPE_DRIVER, 46500, 1024, 1064,

•    1160, 1296, 0, 576, 579, 584, 599, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1024x768@60Hz */
• { DRM_MODE("1024x768", DRM_MODE_TYPE_DRIVER, 63500, 1024, 1072,

•    1176, 1328, 0, 768, 771, 775, 798, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1152x864@60Hz */
• { DRM_MODE("1152x864", DRM_MODE_TYPE_DRIVER, 81750, 1152, 1216,

•    1336, 1520, 0, 864, 867, 871, 897, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1280x720@60Hz */
• { DRM_MODE("1280x720", DRM_MODE_TYPE_DRIVER, 74500, 1280, 1344,

•    1472, 1664, 0, 720, 723, 728, 748, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1280x768@60Hz */
• { DRM_MODE("1280x768", DRM_MODE_TYPE_DRIVER, 79500, 1280, 1344,

•    1472, 1664, 0, 768, 771, 781, 798, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1280x800@60Hz */
• { DRM_MODE("1280x800", DRM_MODE_TYPE_DRIVER, 83500, 1280, 1352,

•    1480, 1680, 0, 800, 803, 809, 831, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1280x1024@60Hz */
• { DRM_MODE("1280x1024", DRM_MODE_TYPE_DRIVER, 109000, 1280, 1368,

•    1496, 1712, 0, 1024, 1027, 1034, 1063, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1360x768@60Hz */
• { DRM_MODE("1360x768", DRM_MODE_TYPE_DRIVER, 84750, 1360, 1432,

•    1568, 1776, 0, 768, 771, 781, 798, 0,
  

•    DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC) },
  

• /* 1366x768@60Hz */
• { DRM_MODE("1366x768", DRM_MODE_TYPE_DRIVER, 85250, 1368, 1440,

Here the hdisplay is 1368, not 1366.

thanks,

Takashi