On Wed, Mar 16, 2022 at 10:00:06AM +0200, Jani Nikula wrote:
On Fri, 18 Feb 2022, Ville Syrjala ville.syrjala@linux.intel.com wrote:
From: Ville Syrjälä ville.syrjala@linux.intel.com
Initialize on-stack modes with drm_mode_init() to guarantee no stack garbage in the list head, or that we aren't copying over another mode's list head.
Based on the following cocci script, with manual fixups: @decl@ identifier M; expression E; @@
- struct drm_display_mode M = E;
- struct drm_display_mode M;
@@ identifier decl.M; expression decl.E; statement S, S1; @@ struct drm_display_mode M; ... when != S
- drm_mode_init(&M, &E);
S1
@@ expression decl.E; @@
- &*E
- E
Signed-off-by: Ville Syrjälä ville.syrjala@linux.intel.com
I wonder if that cocci could be added to scripts/coccinelle or something to detect anyone adding new ones?
Maybe.
Julia & co, would you be open to having drm subsystem specific coccinelle scripts? If so where should we put the? scripts/coccinelle/drm perhaps?