Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set

On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote:

On Mon, 20 Jun 2011 19:36:11 +0200 Wolfram Sang w.sang@pengutronix.de wrote:

...

Commit 6067aa (drm/i915: split clock gating init into per-chipset functions) introduces an init_clock_gating-pointer. There is one case, however, where it does not get set, so that caused an OOPS. Change the code to return -ENODEV in this case and propagate it to the upper layers.

Signed-off-by: Wolfram Sang w.sang@pengutronix.de Cc: Jesse Barnes jbarnes@virtuousgeek.org Cc: Chris Wilson chris@chris-wilson.co.uk

---

Looks good, thanks Wolfram.

Reviewed-by: Jesse Barnes jbarnes@virtuousgeek.org

Just wondering: I don't see it in linux-next or the i915-branches I am aware of. Forgotten or intentional?