Re: [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter

Hi Geert,

Thank you for the review.

On Friday 24 October 2014 15:58:34 Geert Uytterhoeven wrote:

On Fri, Oct 24, 2014 at 2:58 PM, Laurent Pinchart

laurent.pinchart+renesas@ideasonboard.com wrote:

...

--- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -279,4 +279,8 @@ int drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe *frame, const struct drm_display_mode *mode); +struct edid *drm_do_get_edid(struct drm_connector *connector,

•   int (*get_edid_block)(void *, u8 *buf, unsigned int, size_t),
  

It doesn't hurt to add parameter names for all parameters, as hints for implementors.

Good point, I'll fix that.

...

•   void *data);