On Wed, Feb 10, 2021 at 03:26:00PM -0800, Navare, Manasi wrote:
On Wed, Feb 10, 2021 at 05:07:03PM +0200, Ville Syrjälä wrote:
On Wed, Feb 10, 2021 at 01:38:45PM +0000, Simon Ser wrote:
On Wednesday, February 10th, 2021 at 2:16 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Tue, Feb 09, 2021 at 04:14:01PM -0800, Manasi Navare wrote:
These additional checks added to avoid EBUSY give unnecessary WARN_ON in case of big joiner used in i915 in which case even if the modeset is requested on a single pipe, internally another consecutive pipe is stolen and used to drive half of the transcoder timings. So in this case it is expected that requested crtc and affected crtcs do not match. Hence the added WARN ON becomes irrelevant.
The WARN_ON only happens if allow_modeset == false. If allow_modeset == true, then the driver is allowed to steal an unrelated pipe.
Maybe i915 is stealing a pipe without allow_modeset?
No. All page flips etc. will have to get split up internally between multiple crtcs.
So I think there's basically three options: a) massive rewrite of i915 to bypass even more of drm_atomic stuff b) allow i915 to silence that warning, which opens up the question whether the warn is doing any good if it can just be bypassed c) nuke the warning entirely
a) is not going to happen, and it would any way allow i915 to do things any which way it wants without tripping the warn, rendering the warn entirely toothless.
Hmm. Maybe there is a d) which would be to ignore all crtcs that are not logically enabled in the warn? Not sure if that could allow something to slit through that people want it to catch?
Yeah it's option d), because the warning is meant to catch funny uapi that compositors don't want to deal with. So if this bigjoiner stuff in i915 is _really_ fully transparent, then it's ok.
And excluding completely disabled CRTC from this check makes imo sense, since userspace - is not allowed to issue an atomic flip on these (it's off) - is required to set allow_modeset to enable (at which point i915 can internally move CRTC assignments around however it feels like and it's all fine). Once that fully modeset is done we'd again be in sync with userspace's understanding of what's going on. - hence there cannot be a spurious EBUSY to userspace
I think what this needs is a big comment in the code explaining why we can afford to not check this.
So as per the offline IRC discussions,
- We can check for crtc_state->enable and only use the enabled crtcs
in the affected crtc calculation. And this enable would only be set when modeset is done. So in case of bigjoiner no modeset on Pipe A, even if Pipe B is stolen, since no modeset and because that pipe doesnt get enabled the affected crtcs would still be 0x1.
This should solve the problem. Ville, Danvet - I will make this change?
I think you volunteered :-)
Pls Cc: all the people involved in the original patch discussion, so that they can ack the change too.
Cheers, Daniel