Hi, Jitao:
On Tue, 2020-02-25 at 14:46 +0800, Jitao Shi wrote:
Add decriptions about supported chips, including MT2701 & MT8173 & mt8183
descriptions
- Add more chips support. ex. MT2701 & MT8173 & MT8183
- Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set pin mode to gpio oupput-low to avoid leakage current when dpi disable.
- Add property "pclk-sample" to config the dpi sample on falling (0), rising (1), both falling and rising (2).
The title is just about supported chips, so I prefer you move other modification to another patch. Of course, you could use a more rough title to include all what you do so you need not to break this patch.
Signed-off-by: Jitao Shi jitao.shi@mediatek.com
.../bindings/display/mediatek/mediatek,dpi.txt | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt index b6a7e7397b8b..0dee4f7a227e 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt @@ -7,6 +7,7 @@ output bus.
Required properties:
- compatible: "mediatek,<chip>-dpi"
- the supported chips are mt2701 , mt8173 and mt8183.
- reg: Physical base address and length of the controller's registers
- interrupts: The interrupt signal from the function block.
- clocks: device clocks
@@ -16,6 +17,11 @@ Required properties: Documentation/devicetree/bindings/graph.txt. This port should be connected to the input port of an attached HDMI or LVDS encoder chip.
+Optional properties: +- pinctrl-names: Contain "gpiomode" and "dpimode". +- pclk-sample: 0: sample in falling edge, 1: sample in rising edge, 2: sample
- in both falling and rising edge.
pinctrl-names & pclk-sample are defined in another document, please list the reference document, [1] is the sample. For pclk-sample, I think you should modify [2] to add 'sampling in both failing and rising edge'.
[1] Documentation/devicetree/bindings/display/bridge/ti,tfp410.txt [2] Documentation/devicetree/bindings/media/video-interfaces.txt
Example:
dpi0: dpi@1401d000 { @@ -26,6 +32,10 @@ dpi0: dpi@1401d000 { <&mmsys CLK_MM_DPI_ENGINE>, <&apmixedsys CLK_APMIXED_TVDPLL>; clock-names = "pixel", "engine", "pll";
- pclk-sample = 0;
I think you should move pclk-sample into the port node according to [2].
Regards, CK
pinctrl-names = "gpiomode", "dpimode";
pinctrl-0 = <&dpi_pin_gpio>;
pinctrl-1 = <&dpi_pin_func>;
port { dpi0_out: endpoint {