Hi Laurent & Rob :-)
On 04/25/2018 11:01 AM, Laurent Pinchart wrote:
Hi Philippe,
Thank you for the patch.
On Wednesday, 25 April 2018 10:53:13 EEST Philippe Cornu wrote:
Add optional power supplies using the description found in "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)".
There is a single 1v2 supply voltage named vcc12 from which cvcc12 (digital core) and avcc12 (TMDS analog) are derived because according to this data sheet: "cvcc12 and avcc12 can be derived from the same power source"
Shouldn't the power supplies be mandatory, as explained by Mark in https:// lists.freedesktop.org/archives/dri-devel/2018-April/172400.html ?
Laurent, Many thanks Laurent for your comment, I understood the merge of the two 1v2 power supplies but missed the "mandatory" part... maybe because this patch (with optional power supplies) already got the reviewed-by from Rob, I thought the discussion thread you pointed out was applicable "only" to totally new driver documentation.
So, on my side, as a "new user" of sii902x IC, no problem to put these power supplies as mandatory instead of optional properties but I would like to be sure this is applicable to both old and new bindings doc : )
Rob, could you please confirm these power supply properties should be "mandatory"? if yes, should we then modify other optional properties like the reset-gpios too in the future?
Big thanks to both of you, Philippe :-)
Signed-off-by: Philippe Cornu philippe.cornu@st.com
Documentation/devicetree/bindings/display/bridge/sii902x.txt | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/sii902x.txt b/Documentation/devicetree/bindings/display/bridge/sii902x.txt index 56a3e68ccb80..9fb41fc9af51 100644 --- a/Documentation/devicetree/bindings/display/bridge/sii902x.txt +++ b/Documentation/devicetree/bindings/display/bridge/sii902x.txt @@ -8,6 +8,8 @@ Optional properties:
- interrupts-extended or interrupt-parent + interrupts: describe the interrupt line used to inform the host about hotplug events.
- reset-gpios: OF device-tree gpio specification for RST_N pin.
- iovcc-supply: I/O supply voltage (1.8V or 3.3V, host-dependent).
- vcc12-supply: TMDS analog & digital core supply voltage (1.2V).
Optional subnodes:
- video input: this subnode can contain a video input port node