Hi all,
the purpose of this patch series is to address bug reported here [1]. There where two approaches [2,3] to fix this but non of them get mainline. The issue is caused by the fact that we are using devres allocation for the driver (pd,ldb,hdmi,tve) state struct which holds also the 'struct drm_encoder/connector'.
We need to move the driver state containers containing the drm members out of the devres memory management into the drm memory management framework to fix the bug [1]. Therefore we need to split the single driver state struct into two: one for the drm_connector device and one for the drm_encoder device.
The series removes some legacy code paths too and removes the useless imx_drm_encoder_destroy() API.
Pls don't be surprised about the edid memory leak fix patches. I went this way because those patche can be applied independently of the last patch which did the conversion from the devres alloc to the non-devres alloc.
I did the following tests for each component: - probe successful - correct failure handling during probe - bind / unbind (module load/unload)
I also kept a few lines longer than 80char to improve readability.
Other tester are welcome =)
Regards, Marco
[1] https://www.spinics.net/lists/dri-devel/msg189388.html [2] https://lkml.org/lkml/2018/10/16/1148 [3] https://lkml.org/lkml/2019/4/2/612
Marco Felsch (17): drm/imx: drop useless best_encoder callback drm/imx: parallel-display: fix edid memory leak drm/imx: parallel-display: move panel/bridge detection to fail early drm/imx: parallel-display: detach panel within drm_encoder destroy drm/imx: parallel-display: split encoder and decoder states imx/drm: parallel-display: split attach function drm/imx: tve: add regulator_disable devm_action drm/imx: tve: split global state container drm/imx: imx-ldb: remove useless enum drm/imx: imx-ldb: fix edid memory leak drm/imx: imx-ldb: release ldb-channel resources within encoder destroy drm/imx: remove imx_drm_encoder_destroy helper drm/imx: imx-ldb: split imx_ldb devres allocation context drm/imx: imx-ldb: add ldb_is_dual helper drm/imx: imx-ldb: split encoder and decoder states drm/imx: imx-ldb: refactor imx_ldb_bind drm/imx: fix drm_mode_config_cleanup race condition
drivers/gpu/drm/imx/dw_hdmi-imx.c | 28 +- drivers/gpu/drm/imx/imx-drm-core.c | 9 +- drivers/gpu/drm/imx/imx-drm.h | 1 - drivers/gpu/drm/imx/imx-ldb.c | 514 ++++++++++++++----------- drivers/gpu/drm/imx/imx-tve.c | 173 ++++++--- drivers/gpu/drm/imx/ipuv3-crtc.c | 28 +- drivers/gpu/drm/imx/parallel-display.c | 142 ++++--- 7 files changed, 523 insertions(+), 372 deletions(-)