Re: [PATCH v3 1/2] dt-bindings: display/panel: add bindings for S6E88A0-AMS452EF01

Hi Michael.

I fixed the following: - added .yaml extension to $id - added a dsi node to the example, and added #address-cells/size-cells to fix dt_binding_check warnings

With these fixes - applied to drm-misc-next.

Sam

On Thu, Jan 30, 2020 at 09:35:54PM +0100, michael.srba@seznam.cz wrote:

From: Michael Srba Michael.Srba@seznam.cz

This patch adds dts bindings for Samsung AMS452EF01 AMOLED panel, which makes use of their S6E88A0 controller.

Signed-off-by: Michael Srba Michael.Srba@seznam.cz

Hi, I recall now that tabs cause a syntax error in yaml, should be easy to check in checkpatch.pl? I hope there are no more embarassing oversights left.

Changes in v2: use yaml format for the binding Changes in v3: fix oversights too embarassing to admit here

---

.../panel/samsung,s6e88a0-ams452ef01.yaml | 46 +++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml new file mode 100644 index 000000000000..298fc9a78297 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e88a0-ams452ef01.yaml @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,s6e88a0-ams452ef01# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Samsung AMS452EF01 AMOLED panel with S6E88A0 video mode DSI controller

+maintainers:

• • Michael Srba Michael.Srba@seznam.cz

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• const: samsung,s6e88a0-ams452ef01
• reg: true
• reset-gpios: true
• vdd3-supply:

• description: core voltage supply
  

• vci-supply:

• description: voltage supply for analog circuits
  

+required:

• • compatible
• • reg
• • vdd3-supply
• • vci-supply
• • reset-gpios

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• panel@0 {

•        reg = <0>;
  

•        compatible = "samsung,s6e88a0-ams452ef01";
  

•        vdd3-supply = <&pm8916_l17>;
  

•        vci-supply = <&reg_vlcd_vci>;
  

•        reset-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
  

• };

-- 2.24.0