Re: [Intel-gfx] [PATCH v3 02/37] drm/i915: introduce intel_memory_region

Quoting Matthew Auld (2019-08-09 23:26:08)

diff --git a/drivers/gpu/drm/i915/intel_memory_region.c b/drivers/gpu/drm/i915/intel_memory_region.c new file mode 100644 index 000000000000..ef12e462acb8 --- /dev/null +++ b/drivers/gpu/drm/i915/intel_memory_region.c @@ -0,0 +1,175 @@ +// SPDX-License-Identifier: MIT +/*

• • Copyright © 2019 Intel Corporation
• */

+#include "intel_memory_region.h" +#include "i915_drv.h"

+const u32 intel_region_map[] = {

•   [INTEL_MEMORY_SMEM] = BIT(INTEL_SMEM + INTEL_MEMORY_TYPE_SHIFT) | BIT(0),
  

•   [INTEL_MEMORY_LMEM] = BIT(INTEL_LMEM + INTEL_MEMORY_TYPE_SHIFT) | BIT(0),
  

•   [INTEL_MEMORY_STOLEN] = BIT(INTEL_STOLEN + INTEL_MEMORY_TYPE_SHIFT) | BIT(0),
  

This table isn't used? So the meaning of BIT(0) is impenetrable. Should we defer adding the region_map until it is used? -Chris