Re: [PATCH v2] drm/sun4i: Clear encoder->bridge if a bridge is not found

On Thu, Sep 01, 2016 at 02:13:32PM +0800, Chen-Yu Tsai wrote:

The KMS helpers (drm_atomic_helper_check_modeset/mode_fixup) pass encoder->bridge directly to drm_bridge_mode_fixup, which expects a valid pointer, or NULL (in which case it just returns).

Clear encoder->bridge if a bridge is not found, instead of keeping the ERR_PTR value.

Since other drm_bridge functions also follow this pattern of checking for a non-NULL pointer, we can drop the ifs around the calls and just pass the pointer directly.

Fixes: 894f5a9f4b4a ("drm/sun4i: Add bridge support") Signed-off-by: Chen-Yu Tsai wens@csie.org

Applied, thanks! Maxime