On Tue, 2020-09-29 at 23:30 +0300, Ville Syrjälä wrote:
On Tue, Sep 29, 2020 at 08:20:22PM +0000, Souza, Jose wrote:
On Tue, 2020-09-29 at 23:02 +0300, Ville Syrjälä wrote:
On Tue, Sep 29, 2020 at 07:33:45PM +0000, Souza, Jose wrote:
On Tue, 2020-09-29 at 17:41 +0530, Tejas Upadhyay wrote:
JSL has update in vswing table for eDP
Would be nice to mention in the commit description why PCH is being used, that would avoid Ville's question.
If the thing has nothing to do PCH then it should not use the PCH type for the the check. Instead we should just do the EHL/JSL split.
In the first version Matt Roper suggested to use PCH to differentiate between EHL and JSL, Jani also agreed with this solution.This 2 PCHs can only be associate with EHL and JSL respectively, so no downsides here.
The downside is that the code makes no sense on the first glance. It's going to generate a "wtf?" exception in the brain and require me to take a second look to figure what is going on. Exception handling is expensive and shouldn't be needed in cases where it's trivial to make the code 100% obvious.
Adding a comment on the top of jsl_get_combo_buf_trans() would help? Otherwise Tejas you will need to rework this then.