Hi Daniel
On Sun, Nov 3, 2013 at 12:36 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Sun, Nov 03, 2013 at 12:06:05PM +0100, David Herrmann wrote:
Hi Dave
This one can also go into 3.13. This and 2/2 provide the agp_init() cleanup that Daniel suggested for the drm_dev_*() patches. 2/2 is not required, but I thought it was a nice addition.
I have a few more patches to rip out some of the agp init cruft in my demidlayer branch. And they'll conflict with your patch here. If you don't mind I'll pick this one up and rebase it on top of my series.
Fine with me. Then I can drop and ignore them.
Wrt patch 2 I don't see the point - better to just outright kill this callback and inline it like the agp_init one.
2/2 just does a rename. Where do you want to inline it? In drm_pci_exit()? It calls drm_put_dev() which already does a kfree() so we cannot call anything after it. And we cannot call anything before it as ->unload() is called from drm_put_dev().
We could replace drm_put_dev() with: drm_dev_unregister() drm_pci_agp_destroy() drm_dev_free() Or what did you have in mind?
Thanks David