Re: [PATCH 4/4] drm/i915: Use CPU mapping for userspace dma-buf mmap()

On Wed, Aug 12, 2015 at 08:29:13PM -0300, Tiago Vignatti wrote:

Userspace is the one in charge of flush CPU by wrapping mmap with begin{,end}_cpu_access.

v2: Remove LLC check cause we have dma-buf sync providers now. Also, fix return before transferring ownership when mmap fails. v3: Fix return values. v4: !obj->base.filp is user triggerable, so removed the WARN_ON.

Signed-off-by: Tiago Vignatti tiago.vignatti@intel.com

I have some reservations with CPU mmapping on !llc platforms, somehow we need to encourage creation of snooped bo (and proper usage thereof).

However, the patches look good. Reviewed-by: Chris Wilson chris@chris-wilson.co.uk -Chris