On Tue, Jun 10, 2014 at 02:00:37PM +0530, Vandana Kannan wrote:
On Jun-05-2014 2:58 PM, Thierry Reding wrote:
On Thu, Jun 05, 2014 at 02:40:08PM +0530, Vandana Kannan wrote: [...]
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
[...]
/**
- drm_mode_create_aspect_ratio_property - create aspect ratio property
- @dev: DRM device
- Called by a driver the first time it's needed, must be attached to desired
- connectors.
- */
+int drm_mode_create_aspect_ratio_property(struct drm_device *dev) +{
- if (dev->mode_config.aspect_ratio_property)
return 0;- dev->mode_config.aspect_ratio_property =
drm_property_create_enum(dev, 0, "aspect ratio",drm_aspect_ratio_enum_list,ARRAY_SIZE(drm_aspect_ratio_enum_list));- return 0;
Sorry for not noticing this before: what if drm_propert_create_enum() fails? Should that return an error? This function will currently silently ignore failure to create the property.
Thierry
Yes.. I can
- modify this to return the property (which would be NULL if create
fails) and have a NULL check at the calling end or 2. have a NULL check for the property at the calling end keeping the existing implementation or 3. return a non-zero value in case of failure.
I prefer 3. -ENOMEM sounds like a good candidate here.
Thierry