On Tue, Feb 18, 2020 at 02:13:45PM -0600, Rob Herring wrote:
On Sun, Feb 16, 2020 at 12:15 PM Sam Ravnborg sam@ravnborg.org wrote:
Add data-mapping property that can be used to specify the media format used for the connection betwwen the display controller (connector) and the panel. Signed-off-by: Sam Ravnborg sam@ravnborg.org
Missing blank line.
.../devicetree/bindings/display/panel/panel-dpi.yaml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml index 40079fc24a63..6a03d2449701 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-dpi.yaml @@ -21,6 +21,16 @@ properties: - {} - const: panel-dpi
- data-mapping:
- enum:
- rgb24- rgb565- bgr666- lvds666Doesn't lvds666 come from i.MX IPU which as I remember has built-in LVDS block? I'd think this format would be implicit when using the LVDS block and panel. It doesn't seem this is actually used anywhere either.
I must admit that I just copied this list from Oleksandrs original patch. The MEDIA type it identifies(MEDIA_BUS_FMT_RGB666_1X24_CPADHI) looks special. I will drop lvds666 while applying, unless I get other feedback. (Note: travelling, earliest in the weekend)
Btw. anyway I can add data-mapping to panel-common - and then list the allowed enum values in each binding?
I would love to have a central definition of data-mapping, and then let the users only allow the relevant subset so we catch errors in DT files early.
Sam