Hi
On Fri, Jan 15, 2016 at 4:24 PM, Marek Olšák maraeo@gmail.com wrote:
On Fri, Jan 15, 2016 at 12:12 PM, Emil Velikov emil.l.velikov@gmail.com wrote:
On 12 January 2016 at 23:14, Marek Olšák maraeo@gmail.com wrote:
From: Marek Olšák marek.olsak@amd.com
It warns for all "{}" initializers. Well, I want us to use {}.
configure.ac | 3 ++- intel/intel_decode.c | 2 --
The whole of libdrm, minus the intel_decode can get away without using such constructs. And yes that includes radeon and amdgpu.
NACK on this one - please be consistent with existing code base.
Consistent with what? {} is the same as memset on each structure member. The warning says that a structure member is initialized to zero because of {}, which is why {} is used in the first place. It's the same as using memset and getting a warning "memset initializes the memory to zero". How useful is that?
The only use of this warning is to prevent people from learning that {} initializes any non-specified field to 0.
Reviewed-by: David Herrmann dh.herrmann@gmail.com
Thanks David