Re: [PATCH v11] staging: fbtft: add tearing signal detect

Hi Carlis,

On Wed, Jan 27, 2021 at 3:07 PM Carlis zhangxuezhi3@gmail.com wrote:

From: zhangxuezhi zhangxuezhi1@yulong.com

For st7789v ic,when we need continuous full screen refresh, it is best to wait for the TE signal arrive to avoid screen tearing

Signed-off-by: zhangxuezhi zhangxuezhi1@yulong.com

v11: remove devm_gpio_put and change a dev_err to dev_info

--- a/drivers/staging/fbtft/fb_st7789v.c +++ b/drivers/staging/fbtft/fb_st7789v.c

@@ -82,6 +111,32 @@ enum st7789v_command { */ static int init_display(struct fbtft_par *par) {

•   int rc;
  

•   struct device *dev = par->info->device;
  

•   par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0, GPIOD_IN);
  

•   if (IS_ERR(par->gpio.te)) {
  

•           rc = PTR_ERR(par->gpio.te);
  

•           dev_info(par->info->device, "Failed to request te gpio: %d\n", rc);
  

Please slow down and read the feedback. I said "dev_err_probe()", not "dev_info()".

•           return rc;
  

•   }
  

•   if (par->gpio.te) {
  

•           init_completion(&spi_panel_te);
  

•           mutex_init(&te_mutex);
  

•           rc = devm_request_irq(dev,
  

•                                 gpiod_to_irq(par->gpio.te),
  

•                                spi_panel_te_handler, IRQF_TRIGGER_RISING,
  

•                                "TE_GPIO", par);
  

•           if (rc) {
  

•                   dev_err(par->info->device, "TE request_irq failed.\n");
  

Same here.

•                   return rc;
  

•           }
  

•           disable_irq_nosync(gpiod_to_irq(par->gpio.te));
  

•   } else {
  

•           dev_info(par->info->device, "%s:%d, TE gpio not specified\n",
  

•                    __func__, __LINE__);
  

•   }
    /* turn off sleep mode */
    write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
    mdelay(120);
  

Gr{oetje,eeting}s,

Geert