Re: [PATCH v8 6/6] drm_modes: add of_videomode helpers

On Mon, Nov 12, 2012 at 04:37:06PM +0100, Steffen Trumtrar wrote: [...]

+#if IS_ENABLED(CONFIG_OF_VIDEOMODE) +static void dump_drm_displaymode(struct drm_display_mode *m) +{

• pr_debug("drm_displaymode = %d %d %d %d %d %d %d %d %d\n",

•  m->hdisplay, m->hsync_start, m->hsync_end, m->htotal,
  

•  m->vdisplay, m->vsync_start, m->vsync_end, m->vtotal,
  

•  m->clock);
  

I seem to remember a comment to an earlier version of this patch requesting better formatting of this string. Alternatively you might want to consider replacing it using drm_mode_debug_printmodeline().

diff --git a/include/drm/drmP.h b/include/drm/drmP.h

[...]

@@ -1457,6 +1458,10 @@ drm_mode_create_from_cmdline_mode(struct drm_device *dev,

extern int videomode_to_display_mode(struct videomode *vm, struct drm_display_mode *dmode); +extern int of_get_drm_display_mode(struct device_node *np,

• 		   struct drm_display_mode *dmode,
  

• 		   int index);
  

Also requires either a dummy or protection.

Thierry