Hi Rob,
Thanks for the patches. They look good to me, except for the empty commit messages and the odd alignment. For instance, I would have replaced
- drm_connector_property_set_value(connector, + drm_object_property_set_value(&connector->base, dpms_property, DRM_MODE_DPMS_ON);
with
- drm_connector_property_set_value(connector, - dpms_property, - DRM_MODE_DPMS_ON); + drm_object_property_set_value(&connector->base, + dpms_property, + DRM_MODE_DPMS_ON);
Feel free to ignore the alignment issue if you wish.
Other than that,
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
and
Acked-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
for the shmob patch.
On Thursday 11 October 2012 21:05:53 Rob Clark wrote:
From: Rob Clark rob@ti.com
It was suggested by Laurent Pinchart to clean up the legacy connector property functions, as they are no longer needed. This patchset replaces references to and remove the connector property fxns, which have been superseded with the more general object property fxns:
- drm_connector_attach_property -> drm_object_attach_property
- drm_connector_property_set_value -> drm_object_property_set_value
- drm_connector_property_get_value -> drm_object_property_get_value
Rob Clark (9): drm/i915: drm_connector_property -> drm_object_property drm/gma500: drm_connector_property -> drm_object_property drm/nouveau: drm_connector_property -> drm_object_property drm/radeon: drm_connector_property -> drm_object_property drm/shmob: drm_connector_property -> drm_object_property drm/udl: drm_connector_property -> drm_object_property drm/vmwgfx: drm_connector_property -> drm_object_property drm/i2c: drm_connector_property -> drm_object_property drm: remove legacy drm_connector_property fxns
drivers/gpu/drm/drm_crtc.c | 31 +++---------- drivers/gpu/drm/drm_fb_helper.c | 2 +- drivers/gpu/drm/drm_sysfs.c | 6 +-- drivers/gpu/drm/gma500/cdv_device.c | 4 +- drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 6 +-- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 10 ++--- drivers/gpu/drm/gma500/mdfld_dsi_output.c | 10 ++--- drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +- drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +- drivers/gpu/drm/gma500/oaktrail_lvds.c | 8 ++-- drivers/gpu/drm/gma500/psb_intel_lvds.c | 10 ++--- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 24 +++++----- drivers/gpu/drm/i2c/ch7006_drv.c | 20 ++++----- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_lvds.c | 2 +- drivers/gpu/drm/i915/intel_modes.c | 4 +- drivers/gpu/drm/i915/intel_sdvo.c | 24 +++++----- drivers/gpu/drm/i915/intel_tv.c | 14 +++--- drivers/gpu/drm/nouveau/nouveau_connector.c | 22 ++++----- drivers/gpu/drm/nouveau/nv17_tv.c | 16 +++---- drivers/gpu/drm/radeon/radeon_connectors.c | 62 +++++++++++------------ drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 +- drivers/gpu/drm/udl/udl_connector.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c | 2 +- include/drm/drm_crtc.h | 8 ---- 29 files changed, 137 insertions(+), 166 deletions(-)