Re: [PATCH] allow 32bpp framebuffers for cirrus drm

On Di, 2014-10-28 at 17:04 +0000, Zachary Reizner wrote:

    revision bump would be needed when adding a new interface (not
    present
    in real hardware) to allow for larger pitches, so you could
    use 32bpp
    with the default (1024x768) resolution.

I did not change the pitch mechanism.

Sure. That was Adams idea to make the patch more useful.

The hardware is limited to less than a 4KB pitch because of the registers, so I kept that limitation in the driver. That means no revision bump is necessary.

Yes, but it also implies that 32bpp will work on very low resolutions only (excluding the default res of 1024x768). I don't think the patch is very useful because of that. Nevertheless no objections to include it from my side.

cheers, Gerd