10 Oct
2014
10 Oct
'14
2:25 a.m.
Hi,
On Wed, Oct 08, 2014 at 12:00:27PM -0400, Jerome Glisse wrote:
[...]
And now all ioctl go through this single entry point :
int radeon_ioctl_stub(int ioctl, void *data, ...) { struct radeon_ioctl *rio = data;
return rdispatch_ioctls[rio->version][ioctl](data, ...); }
I advise against this: it's essentially implementing IOCTLs on top of an IOCTL...
It doesn't really reduce the maintenance burden: just moves it from the standard IOCTL dispatching to a custom mechanism; while adding extra complexity, and making the interface more opaque. (Think strace, or Valgrind.)
-antrik-