Quoting Sankeerth Billakanti (2022-03-16 10:35:48)
Enable backlight support for eDP panel on CRD platform for sc7280.
Signed-off-by: Sankeerth Billakanti quic_sbillaka@quicinc.com
Changes in v5:
- Separate out backlight nodes
arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts index 2df654e..16d1a5b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts @@ -37,6 +37,15 @@ pinctrl-0 = <&edp_panel_power>; };
edp_backlight: edp-backlight {
Does this also move to qcard.dtsi? Why can't this be combined with the previous patch?
compatible = "pwm-backlight";power-supply = <&vreg_edp_bp>;pwms = <&pm8350c_pwm 3 65535>;enable-gpios = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>;};vreg_edp_bp: vreg-edp-bp-regulator { compatible = "regulator-fixed"; regulator-name = "vreg_edp_bp";@@ -123,7 +132,9 @@ ap_ts_pen_1v8: &i2c13 { edp_panel: edp-panel { compatible = "edp-panel";
backlight = <&edp_backlight>; power-supply = <&edp_3v3_regulator>;
Nitpick: Remove this newline from this hunk and put it in when power-supply is introduced.
ports { #address-cells = <1>; #size-cells = <0>;@@ -172,6 +183,13 @@ ap_ts_pen_1v8: &i2c13 { }; };
+&pm8350c_pwm {
status = "okay";pinctrl-names = "default";pinctrl-0 = <&edp_bl_pwm>;
I see the pinctrl is used now but it would be easier to review this patch if the pinctrl was in this patch.