On 9/23/2015 1:52 PM, Sharma, Shashank wrote:
Since color manager properties are meant as a new standardize KMS extension (we put them into the core drm_crtc_state) the get/set support should also be in the core. See e.g. how the rotation property is handled in drm_atomic_plane_get/set_property. So all this code should be added to drm_atomic_crtc_get/set_property.
Thanks, sounds like a good one. Will move this.
Actually, while implementing this, I realized that this change is not required. What we want to do in drm_atomic_crtc_get/set code is: if (prop == config->cm_palette_after_ctm_property || prop == config->cm_palette_before_ctm_property) { crtc->funcs->atomic_get_property(); }
Which is already being done in the current code: else if (crtc->funcs->atomic_get_property) return crtc->funcs->atomic_get_property(crtc, state, property, val);
so I dont really think we need this change.
Regards Shashank