Re: [PATCH V5 3/7] dw-hdmi: make checkpatch happy

Hi ZubairLK: On 2014年11月10日 17:22, Zubair Lutfullah Kakakhel wrote:

Hi Andy,

In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c

Have these errors come during the previous 2 patches.

If yes, then these changes need to be squashed into the previous patches. No patch should add a checkpatch error and then fix it in a later patch.

Regards ZubairLK

i use checkpatch with --subjective

On 08/11/14 05:29, Andy Yan wrote:

...

CHECK: Alignment should match open parenthesis

•   if ((hdmi->vic == 10) || (hdmi->vic == 11) ||
  

•           (hdmi->vic == 12) || (hdmi->vic == 13) ||
  
  

CHECK: braces {} should be used on all arms of this statement

•   if (hdmi->hdmi_data.video_mode.mdvi)
  

[...]

•   else {
  

[...]

Signed-off-by: Andy Yan andy.yan@rock-chips.com

drivers/gpu/drm/bridge/dw_hdmi.c | 97 ++++++++++++++++++++-------------------- 1 file changed, 48 insertions(+), 49 deletions(-)