RE: [PATCH v10 32/40] misc/mei/hdcp: Repeater topology verification and ack

-----Original Message----- From: C, Ramalingam Sent: Thursday, January 31, 2019 12:30 PM To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; daniel.vetter@ffwll.ch; Winkler, Tomas tomas.winkler@intel.com; Shankar, Uma uma.shankar@intel.com Cc: C, Ramalingam ramalingam.c@intel.com Subject: [PATCH v10 32/40] misc/mei/hdcp: Repeater topology verification and ack

Request ME to verify the downstream topology information received.

ME FW will validate the Repeaters receiver id list and downstream topology.

On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack.

v2: Rebased. v3: cldev is passed as first parameter [Tomas] Redundant comments and cast are removed [Tomas] v4: %zd for ssize_t [Alexander] %s/return -1/return -EIO [Alexander] Style and typos fixed [Uma] v5: Rebased. v6: Rebasing. v7: Adjust to the new mei interface. Fix for Kdoc. v8: K-Doc addition. [Tomas]

Signed-off-by: Ramalingam C ramalingam.c@intel.com Reviewed-by: Uma Shankar uma.shankar@intel.com

Latest set looks ok. You can keep the RB.

---

drivers/misc/mei/hdcp/mei_hdcp.c | 76 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 75 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/mei/hdcp/mei_hdcp.c b/drivers/misc/mei/hdcp/mei_hdcp.c index 2be7b6b949c2..c157c18371b4 100644 --- a/drivers/misc/mei/hdcp/mei_hdcp.c +++ b/drivers/misc/mei/hdcp/mei_hdcp.c @@ -449,6 +449,80 @@ static int mei_get_session_key(struct device *dev, struct hdcp_port_data *data, return 0; }

+/**

• • mei_repeater_check_flow_prepare_ack() - Validate the Downstream

+topology

• • and prepare rep_ack.
• • @dev: device corresponding to the mei_cl_device
• • @hdcp_data: Intel HW specific hdcp data
• • @rep_topology: Receiver ID List to be validated
• • @rep_send_ack : repeater ack from ME FW.
• • Return: 0 on Success, <0 on Failure
• */

+static int +mei_repeater_check_flow_prepare_ack(struct device *dev,

• 		    struct hdcp_port_data *data,
  

• 		    struct hdcp2_rep_send_receiverid_list
  

• 					*rep_topology,
  

• 		    struct hdcp2_rep_send_ack *rep_send_ack) {
  

• struct wired_cmd_verify_repeater_in verify_repeater_in = { { 0 } };
• struct wired_cmd_verify_repeater_out verify_repeater_out = { { 0 } };
• struct mei_cl_device *cldev;
• ssize_t byte;
• if (!dev || !rep_topology || !rep_send_ack || !data)

• return -EINVAL;
  

• cldev = to_mei_cl_device(dev);
• verify_repeater_in.header.api_version = HDCP_API_VERSION;
• verify_repeater_in.header.command_id = WIRED_VERIFY_REPEATER;
• verify_repeater_in.header.status = ME_HDCP_STATUS_SUCCESS;
• verify_repeater_in.header.buffer_len =
• WIRED_CMD_BUF_LEN_VERIFY_REPEATER_IN;
• verify_repeater_in.port.integrated_port_type = data->port_type;
• verify_repeater_in.port.physical_port =

• 			(u8)GET_MEI_DDI_INDEX(data->port);
  

• memcpy(verify_repeater_in.rx_info, rep_topology->rx_info,

•       HDCP_2_2_RXINFO_LEN);
  

• memcpy(verify_repeater_in.seq_num_v, rep_topology->seq_num_v,

•       HDCP_2_2_SEQ_NUM_LEN);
  

• memcpy(verify_repeater_in.v_prime, rep_topology->v_prime,

•       HDCP_2_2_V_PRIME_HALF_LEN);
  

• memcpy(verify_repeater_in.receiver_ids, rep_topology->receiver_ids,

•       HDCP_2_2_RECEIVER_IDS_MAX_LEN);
  

• byte = mei_cldev_send(cldev, (u8 *)&verify_repeater_in,

• 	      sizeof(verify_repeater_in));
  

• if (byte < 0) {

• dev_dbg(dev, "mei_cldev_send failed. %zd\n", byte);
  

• return byte;
  

• }
• byte = mei_cldev_recv(cldev, (u8 *)&verify_repeater_out,

• 	      sizeof(verify_repeater_out));
  

• if (byte < 0) {

• dev_dbg(dev, "mei_cldev_recv failed. %zd\n", byte);
  

• return byte;
  

• }
• if (verify_repeater_out.header.status != ME_HDCP_STATUS_SUCCESS) {

• dev_dbg(dev, "ME cmd 0x%08X failed. status: 0x%X\n",
  

• 	WIRED_VERIFY_REPEATER,
  

• 	verify_repeater_out.header.status);
  

• return -EIO;
  

• }
• memcpy(rep_send_ack->v, verify_repeater_out.v,

•       HDCP_2_2_V_PRIME_HALF_LEN);
  

• rep_send_ack->msg_id = HDCP_2_2_REP_SEND_ACK;
• return 0;

+}

static __attribute__((unused)) struct i915_hdcp_component_ops mei_hdcp_ops = { .owner = THIS_MODULE, @@ -459,7 +533,7 @@ struct i915_hdcp_component_ops mei_hdcp_ops = { .initiate_locality_check = mei_initiate_locality_check, .verify_lprime = mei_verify_lprime, .get_session_key = mei_get_session_key,

• .repeater_check_flow_prepare_ack = NULL,

• .repeater_check_flow_prepare_ack =

+mei_repeater_check_flow_prepare_ack, .verify_mprime = NULL, .enable_hdcp_authentication = NULL, .close_hdcp_session = NULL, -- 2.7.4