Hi Deepak,
On 6 September 2018 at 00:47, Deepak Rawat drawat@vmware.com wrote:
With drm subsystem using struct drm_rect to manage rectangular area this export it to user-space.
Currently used by drm_mode_atomic blob property FB_DAMAGE_CLIPS.
--- a/include/drm/drm_mode.h +++ b/include/drm/drm_mode.h
Please see include/drm/README for details how include/drm/ should be updated.
--- a/xf86drmMode.h +++ b/xf86drmMode.h @@ -338,6 +338,8 @@ typedef struct _drmModePlaneRes { uint32_t *planes; } drmModePlaneRes, *drmModePlaneResPtr;
+typedef struct drm_mode_rect drmModeRect, *drmModeRectPtr;
Since there's no API which (directly) uses drmModeRect I'd stick with the original name and drop the typedef? Otherwise it's fairly confusing to have it as-is.
HTH Emil