On Sun, 9 Feb 2020 at 22:56, Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Thanks!
Cc: Ben Skeggs bskeggs@redhat.com Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Greg Kroah-Hartman gregkh@linuxfoundation.org
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_debugfs.c b/drivers/gpu/drm/nouveau/nouveau_debugfs.c index 080e964d49aa..d1c82fc45a68 100644 --- a/drivers/gpu/drm/nouveau/nouveau_debugfs.c +++ b/drivers/gpu/drm/nouveau/nouveau_debugfs.c @@ -224,14 +224,10 @@ nouveau_drm_debugfs_init(struct drm_minor *minor) struct dentry *dentry; int i;
for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++) {dentry = debugfs_create_file(nouveau_debugfs_files[i].name,S_IRUGO | S_IWUSR,minor->debugfs_root, minor->dev,nouveau_debugfs_files[i].fops);if (!dentry)return -ENOMEM;}
for (i = 0; i < ARRAY_SIZE(nouveau_debugfs_files); i++)debugfs_create_file(nouveau_debugfs_files[i].name,S_IRUGO | S_IWUSR, minor->debugfs_root,minor->dev, nouveau_debugfs_files[i].fops); drm_debugfs_create_files(nouveau_debugfs_list, NOUVEAU_DEBUGFS_ENTRIES,-- 2.25.0
Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau