Re: [PATCH] drm/gma500: select framebuffer dependency

Hi,

On 4/8/22 19:59, James Hilliard wrote:

This appears to be needed for video output to function correctly.

More proof/justification?

Signed-off-by: James Hilliard james.hilliard1@gmail.com

drivers/gpu/drm/gma500/Kconfig | 2 ++ 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig index 0cff20265f97..ff8c7b6e87f5 100644 --- a/drivers/gpu/drm/gma500/Kconfig +++ b/drivers/gpu/drm/gma500/Kconfig @@ -7,6 +7,8 @@ config DRM_GMA500 select ACPI_VIDEO if ACPI select BACKLIGHT_CLASS_DEVICE if ACPI select INPUT if ACPI

• select FB

Preferably depends on FB

There are a few instances of an arch (or board) selecting FB, which makes some sense, but other drivers shouldn't be doing that IMO.

• select FB_EFI if EFI help Say yes for an experimental 2D KMS framebuffer driver for the Intel GMA500 (Poulsbo), Intel GMA600 (Moorestown/Oak Trail) and

thanks.