Re: [PATCH v1 3/7] mfd: add atmel-lcdc driver

Hi Lee.

...

+static const struct mfd_cell lcdc_cells[] = {

• {

• .name = "atmel-lcdc-pwm",
  

• .of_compatible = "atmel,lcdc-pwm",
  

• },
• {

• .name = "atmel-lcdc-dc",
  

• .of_compatible = "atmel,lcdc-display-controller",
  

• },

+};

Will you be adding any more devices, or is this the entirety of the device? If the latter, I suggest that this doesn't warrant being an MFD.

Thats it. And others agree with you that this is not a good approach. So in v2 there will be no MFD.

Thanks for confirming that the non-mfd way is the better approach.

Sam