On 2/23/22 18:12, Michal Suchánek wrote:
On Wed, Feb 23, 2022 at 05:54:54PM +0100, Javier Martinez Canillas wrote:
[snip]
Yes, that's what I tried to say. But your commit message says "To enable use of VESA modes with simplefb in legacy BIOS boot mode" and that isn't accurate AFAIU (unless you meant sysfb instead).
config SYSFB_SIMPLEFB bool "Mark VGA/VBE/EFI FB as generic system framebuffer" depends on SYSFB
select BOOT_VESA_SUPPORT if X86This to me means that it's simplefb specifically that requires it, not sysfb. More precisely SYSFB_SIMPLEFB which is the simplefb implementation on top of legacy BIOS.
Ok, I see what you meant. The fact that simplefb is what's named to the part of the sysfb driver that register the "simple-framebuffer" platform device and also the name of the fbdev driver that matches the "simple-framebuffer" is too confusing.
My point about the subject line remains thought, I would use something like:
firmware: sysfb: Enable boot time VESA graphic mode selection for simplefb
But I'll stop bike-shedding this. I don't mind if you keep the current line and feel free to keep my r-b tag.
Best regards,