On Mon, Jun 07, 2021 at 09:38:58PM +0200, Michal Wajdeczko wrote:
On 07.06.2021 19:45, Matthew Brost wrote:
On Mon, Jun 07, 2021 at 11:03:51AM -0700, Matthew Brost wrote:
From: Michal Wajdeczko michal.wajdeczko@intel.com
GuC ABI documentation is now ready to be included in i915.rst
Signed-off-by: Michal Wajdeczko michal.wajdeczko@intel.com Signed-off-by: Matthew Brost matthew.brost@intel.com Cc: Piotr Piórkowski piotr.piorkowski@intel.com
Michal - I noticed while putting this series together that there is kernel doc in intel_guc_ct.* but this isn't inclued in i915.rst. Do you think we should add the those here or in a new section (e.g. GuC CTBs)?
Let me know what you think and I can fix this up before this gets merged.
What's in intel_guc_ct.* is implementation detail, that should be placed in separate section, while this patch adds pure ABI definitions that deserve its own dedicated section.
Sounds good. Will fix that in the next rev.
Btw, this patch does not need to be squashed with others, as it is about updating .rst only and is not breaking anything. Same for patch 1/13 that introduces new definitions in new .h file.
Agree. What I said in the cover letter isn't 100% correct as some of patches probably don't have to be squashed. Next rev I'll go through patch by patch and figure that part out.
Matt
Michal
With that, for this patch:
Reviewed-by: Matthew Brost matthew.brost@intel.com
Documentation/gpu/i915.rst | 8 ++++++++ 1 file changed, 8 insertions(+)
diff --git a/Documentation/gpu/i915.rst b/Documentation/gpu/i915.rst index 42ce0196930a..c7846b1d9293 100644 --- a/Documentation/gpu/i915.rst +++ b/Documentation/gpu/i915.rst @@ -518,6 +518,14 @@ GuC-based command submission .. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c :doc: GuC-based command submission
+GuC ABI +~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h +.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h
HuC
.. kernel-doc:: drivers/gpu/drm/i915/gt/uc/intel_huc.c
2.28.0
Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx