On Thu, Sep 16, 2021 at 08:53:50PM -0700, Stephen Boyd wrote:
Quoting Sean Paul (2021-09-15 13:38:29)
From: Sean Paul seanpaul@chromium.org
encoder->commit() was being misused because there were some global resources which needed to be tweaked in encoder->enable() which were not accessible in dpu_encoder.c. That is no longer true and the redirect serves no purpose any longer. So remove the indirection.
When did it become false? Just curious when this became obsolete.
In commit
commit cd6d923167b1bf3e051f9d90fa129456d78ef06e Author: Rob Clark robdclark@chromium.org Date: Thu Aug 29 09:45:17 2019 -0700
drm/msm/dpu: async commit support
There was a call to dpu_crtc_commit_kickoff() which was removed from dpu_kms_encoder_enable(). That was the bit which required the back-and-forth between ->enable() and ->commit().
Signed-off-by: Sean Paul seanpaul@chromium.org Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-11-sean@p... #v1
Changes in v2:
-None
Reviewed-by: Stephen Boyd swboyd@chromium.org Tested-by: Stephen Boyd swboyd@chromium.org
Thanks!