Hi Kieran, Jacopo,
On Wed, Sep 11, 2019 at 8:16 PM Kieran Bingham kieran.bingham+renesas@ideasonboard.com wrote:
On 06/09/2019 14:54, Jacopo Mondi wrote:
Add CMM units to Renesas R-Car Gen3 SoC that support it, and reference them from the Display Unit they are connected to.
Sort the 'vsps' and 'renesas,cmm' entries in the DU unit consistently in all the involved DTS.
I think if you chose the ordering in the r8a7795, then you only have to adjust/correct the ordering in the r8a7796 and r8a77965 ...
Especially as you haven't changed the ordering of r8a77970, and r8a77980 which have the status after the vsps entry.
Signed-off-by: Jacopo Mondi jacopo+renesas@jmondi.org
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -3142,9 +3178,11 @@ <&cpg CPG_MOD 722>, <&cpg CPG_MOD 721>; clock-names = "du.0", "du.1", "du.2", "du.3";
vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>; status = "disabled";I'm not sure the vsps should be below the status = disabled line.
I'd have this as:
clock-names... vsps... renesas,cmms... <blank line> status... <blank line> ports...
Indeed.
And better write "ports { ... }", so it's clear this is a subnode.
vsps = <&vspd0 0>, <&vspd1 0>, <&vspd2 0>, <&vspd0 1>;
And the above will become "renesas,vsps", needing another reordering?
renesas,cmms = <&cmm0 &cmm1 &cmm2 &cmm3>;I think these should be separated by comma's to show they are separate references, or references to separate phandles or such.
Yep, looks better, and makes the grouping clear.
The only precedence I could find was in pmu_a53:
interrupt-affinity = <&a53_0>, <&a53_1>, <&a53_2>, <&a53_3>;
That's because most other phandle stuff has #<foo>-cells as non-zero.
We do have
clocks = ... <&audio_clk_a>, <&audio_clk_b>, <&audio_clk_c>;
Gr{oetje,eeting}s,
Geert