Re: [PATCH] drm/mcde: Fix unbalanced regulator

On Sun, Nov 08, 2020 at 12:35:35PM +0100, Linus Walleij wrote:

Since we now turn off the EPOD regulator to reset the hardware, we need to balance the regulators after that point. If registering the master fails we only need to disable one regulator. Fix this by open-coding this leg of the error path.

Cc: Stephan Gerhold stephan@gerhold.net Fixes: c4842d4d0f74 ("drm/mcde: Fix display pipeline restart") Signed-off-by: Linus Walleij linus.walleij@linaro.org

Looked for a devm variant of regulator_enable() but they do not seem to exist. So the way the patch does it seems the best way.

Reviewed-by: Sam Ravnborg sam@ravnborg.org

Sam