Re: [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support

On 6/23/22 04:56, ChiaEn Wu wrote:

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index a49979f..a8c58c3 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -244,6 +244,17 @@ config LEDS_MT6323 This option enables support for on-chip LED drivers found on Mediatek MT6323 PMIC.

+config LEDS_MT6370_RGB

• tristate "LED Support for Mediatek MT6370 PMIC"
• depends on LEDS_CLASS
• depends on MFD_MT6370
• select LINEAR_RANGE
• help

•  Say Y here to enable support for MT6370_RGB LED device.
  

•  In MT6370, there are four channel current-sink LED drivers that
  

•  support hardware pattern for const current, PWM, and breath mode.
  

Spell out "constant" (if that is what "const" means here). ?

•  Isink4 channel can also be used as a CHG_VIN power good indicator.