Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 bindings

On Sat, Jan 30, 2021 at 07:10:13PM +0100, Marek Vasut wrote:

Add DT binding document for TI SN65DSI83 DSI to LVDS bridge.

Signed-off-by: Marek Vasut marex@denx.de Cc: Douglas Anderson dianders@chromium.org Cc: Laurent Pinchart laurent.pinchart@ideasonboard.com Cc: Linus Walleij linus.walleij@linaro.org Cc: Sam Ravnborg sam@ravnborg.org Cc: Stephen Boyd swboyd@chromium.org Cc: devicetree@vger.kernel.org To: dri-devel@lists.freedesktop.org

---

.../bindings/display/bridge/ti,sn65dsi83.yaml | 128 ++++++++++++++++++ 1 file changed, 128 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml new file mode 100644 index 000000000000..77e1bafd8cd8 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -0,0 +1,128 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/ti,sn65dsi83.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: SN65DSI83 DSI to LVDS bridge chip

+maintainers:

• • Marek Vasut marex@denx.de

+description: |

• The Texas Instruments SN65DSI83 bridge takes MIPI DSI in and outputs LVDS.
• https://www.ti.com/general/docs/lit/getliterature.tsp?genericPartNumber=sn65...

+properties:

• compatible:
• const: ti,sn65dsi83
• reg:
• const: 0x2d
• enable-gpios:
• maxItems: 1
• description: GPIO specifier for bridge_en pin (active high).
• ports:
• type: object
• additionalProperties: false
• properties:

•  "#address-cells":
  

•    const: 1
  

•  "#size-cells":
  

•    const: 0
  

•  port@0:
  

•    type: object
  

•    additionalProperties: false
  

•    description:
  

•      Video port for MIPI DSI input
  

•    properties:
  

•      reg:
  

•        const: 0
  

•      endpoint:
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•          data-lanes:
  

•            description: array of physical DSI data lane indexes.
  

This all needs to use graph.yaml and video-interfaces.yaml. The latter is in the media tree. See examples there for what to do. It will have to wait for rc1 to apply to drm-misc.

For data-lanes, you need to specify how many lanes are valid. If there's only 1 possible setting (in the h/w, not driver), then it doesn't need to be in DT.

I agree with Doug on adding the regulators. Hard to get wrong in the binding. You or someone can add them to the driver when you can test.

•    required:
  

•      - reg
  

•  port@1:
  

•    type: object
  

•    additionalProperties: false
  

•    description:
  

•      Video port for LVDS output (panel or bridge).
  

•    properties:
  

•      reg:
  

•        const: 1
  

•      endpoint:
  

•        type: object
  

•        additionalProperties: false
  

•        properties:
  

•          remote-endpoint: true
  

•    required:
  

•      - reg
  

• required:

•  - "#address-cells"
  

•  - "#size-cells"
  

•  - port@0
  

•  - port@1
  

+required:

• • compatible
• • reg
• • enable-gpios
• • ports

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/gpio/gpio.h>
• i2c {

•  #address-cells = <1>;
  

•  #size-cells = <0>;
  

•  bridge@2d {
  

•    compatible = "ti,sn65dsi83";
  

•    reg = <0x2d>;
  

•    enable-gpios = <&gpio2 1 GPIO_ACTIVE_HIGH>;
  

•    ports {
  

•      #address-cells = <1>;
  

•      #size-cells = <0>;
  

•      port@0 {
  

•        reg = <0>;
  

•        endpoint {
  

•          remote-endpoint = <&dsi0_out>;
  

•          data-lanes = <1 2 3 4>;
  

•        };
  

•      };
  

•      port@1 {
  

•        reg = <1>;
  

•        endpoint {
  

•          remote-endpoint = <&panel_in_lvds>;
  

•        };
  

•      };
  

•    };
  

•  };
  

• };

-- 2.29.2