Hi Jonathan,
Thanks for your helpful comments, and I have some questions want to ask you below.
Jonathan Cameron jic23@kernel.org 於 2022年6月18日 週六 晚上11:39寫道：
On Mon, 13 Jun 2022 19:11:38 +0800 ChiaEn Wu peterwu.pub@gmail.com wrote:
From: ChiaEn Wu chiaen_wu@richtek.com
Add ABI documentation for mt6370 non-standard ADC sysfs interfaces.
Signed-off-by: ChiaEn Wu chiaen_wu@richtek.com
.../ABI/testing/sysfs-bus-iio-adc-mt6370 | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-mt6370
diff --git a/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6370 b/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6370 new file mode 100644 index 000000000000..039b3381176a --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-iio-adc-mt6370 @@ -0,0 +1,36 @@ +What: /sys/bus/iio/devices/iio:deviceX/in_voltage0_raw
Unfortunately the kernel documentation build scripts do no support duplicating standard ABI for particular devices so as to provide more information. Hence you can't have anything in this file.
I want to confirm with you again, because my ABI file duplicates with standard sysfs-bus-iio (voltage, current, and temperature channels), Should I just remove this ABI file and modify the code of mt6370-adc to meet your expectations??
+KernelVersion: 5.18 +Contact: chiaen_wu@richtek.com +Description:
Indicated MT6370 VBUS ADC with lower accuracy(+-75mA)Curious though, voltage with a mA accuracy range?
Yes, this description is based on the data sheet.
This scale should be presented directly to userspace anyway so no need for this doc.
higher measure range(1~22V)Calculating with scale returns voltage in uVNo. All channels return in mV. That's the ABI requirement as in sysfs-bus-iio and we cannot vary if for particular drivers. If we did no generic tooling would work.
Ok, I got it!
+What: /sys/bus/iio/devices/iio:deviceX/in_voltage1_raw +KernelVersion: 5.18 +Contact: chiaen_wu@richtek.com +Description:
Indicated MT6370 VBUS ADC with higher accuracy(+-30mA)lower measure range(1~9.76V)Calculating with scale offset returns voltage in uV+What: /sys/bus/iio/devices/iio:deviceX/in_voltage4_raw +KernelVersion: 5.18 +Contact: chiaen_wu@richtek.com +Description:
Indicated MT6370 TS_BAT ADCCalculating with scale returns voltage in uV+What: /sys/bus/iio/devices/iio:deviceX/in_voltage7_raw +KernelVersion: 5.18 +Contact: chiaen_wu@richtek.com +Description:
Indicated MT6370 CHG_VDDP ADCCalculating with scale returns voltage in mV+What: /sys/bus/iio/devices/iio:deviceX/in_temp8_raw +KernelVersion: 5.18 +Contact: chiaen_wu@richtek.com +Description:
Indicated MT6370 IC junction temperatureCalculating with scale and offset returns temperature in degree
Shall I modify the scale of temperature to milli degrees in mt6370-adc.c and remove this item??
Best regards, ChiaEn Wu