Hi YoungJun,
Thank you for the patch.
On Monday 21 April 2014 21:28:33 YoungJun Cho wrote:
This patch adds I80 interface for FIMD to support command mode panel.
For this, the below features are added:
- Sets display interface mode relevant registers properly according to the interface type from DT
- Adds drm_panel_cpu_timings structure
. The command mode panel sets them as the private attributes in struct drm_display_mode and FIMD gets them by fimd_mode_set().
- Adds TE interrupt handler . FIMD driver should know TE signal from lcd panel to avoid tearing issue.
- Adds trigger feature . In case of command mode panel, FIMD should set trigger bit, so that image data has to be transferred to display bus or lcd panel.
Changelog v2:
- Moves CPU timings relevant properties to panel DT (commented by Laurent Pinchart, Andrzej Hajda)
Signed-off-by: YoungJun Cho yj44.cho@samsung.com Acked-by: Inki Dae inki.dae@samsung.com Acked-by: Kyungmin Park kyungmin.park@samsung.com
drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_drm_crtc.c | 11 ++ drivers/gpu/drm/exynos/exynos_drm_crtc.h | 2 + drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 + drivers/gpu/drm/exynos/exynos_drm_dsi.c | 13 ++ drivers/gpu/drm/exynos/exynos_drm_fimd.c | 280 ++++++++++++++++++++++----- include/drm/drm_mipi_dsi.h | 2 + include/drm/drm_panel.h | 7 +
Could you please split the DRM core changes into two separate standalone patches (as they're unrelated to each other) ?
include/video/samsung_fimd.h | 3 +- 9 files changed, 277 insertions(+), 44 deletions(-)
[snip]