On Mon, Jan 04, 2016 at 07:53:36AM +0100, Daniel Vetter wrote:
Another pile of vfuncs from the old gpu.tmpl xml documentation that I've forgotten to delete. I spotted a few more things to clarify/extend in the new kerneldoc while going through this once more.
v2: Spelling fixes (Thierry).
Found a couple more.
diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h index 29e0dc50031d..ce5cbf63b5cf 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -131,6 +131,12 @@ struct drm_crtc_helper_funcs { * Atomic drivers which need to inspect and adjust more state should * instead use the @atomic_check callback. *
* Also beware that the neither core nor helpers filter modes before
I'd drop the "the" above: "... that neither core nor helpers..."
* passing the to the driver. More specifically modes rejected by the
"passing them"?
* ->mode_valid callback from #drm_connector_helper_funcs can still be* requested by userspace and therefore also need to be rejected in* either this hook, or the one in #drm_encoder_helper_funcs.*
- RETURNS:
- True if an acceptable configuration is possible, false if the modeset
@@ -188,7 +194,9 @@ struct drm_crtc_helper_funcs { * This callback is used by the legacy CRTC helpers to set a new * framebuffer and scanout position. It is optional and used as an * optimized fast-path instead of a full mode set operation with all the
* resulting flickering. Since it can't update other planes it's
* resulting flickering. If it is not present* drm_crtc_helper_set_config() will fall back to a full modeset, using* the ->mode_set() callbac. Since it can't update other planes it's
"callback"
* incompatible with atomic modeset support. * * This callback is only used by the CRTC helpers and deprecated.@@ -439,6 +447,12 @@ struct drm_encoder_helper_funcs { * Atomic drivers which need to inspect and adjust more state should * instead use the @atomic_check callback. *
* Also beware that the neither core nor helpers filter modes before* passing the to the driver. More specifically modes rejected by the
Same as above.
Thierry