Re: [PATCH] [RESEND] drm: fb_helper: fix CONFIG_FB dependency

On 10/27/21 14:52, Arnd Bergmann wrote:

[snip]

...

@@ -104,7 +105,6 @@ config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" depends on DRM depends on FB

•   select DRM_KMS_HELPER
    select FB_CFB_FILLRECT
    select FB_CFB_COPYAREA
    select FB_CFB_IMAGEBLIT
  

This fails because of all the other drivers that try to 'select DRM_KMS_HELPER'. Kconfig will now complain about a symbol that gets selected while its dependencies are not met.

To work around that, every single driver that has 'selects DRM_KMS_HELPER' would now have to also list 'depends on (DRM_FBDEV_EMULATION && FB) || !DRM_FBDEV_EMULATION'.

Ah, I see now. Thanks a lot for the explanation.

   Arnd

Best regards,