On Wed, Nov 17, 2021 at 09:19:38AM -0600, Rob Herring wrote:
On Wed, Nov 17, 2021 at 8:34 AM Sascha Hauer s.hauer@pengutronix.de wrote:
This enabled the VOP2 display controller along with hdmi and the required port routes which is enough to get a picture out of the hdmi port of the board.
Signed-off-by: Sascha Hauer s.hauer@pengutronix.de
.../boot/dts/rockchip/rk3568-evb1-v10.dts | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts index 184e2aa2416af..156e001492173 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dts @@ -106,6 +106,12 @@ &gmac1m1_rgmii_clk status = "okay"; };
+&hdmi {
status = "okay";avdd-0v9-supply = <&vdda0v9_image>;avdd-1v8-supply = <&vcca1v8_image>;+};
&i2c0 { status = "okay";
@@ -390,3 +396,21 @@ &sdmmc0 { &uart2 { status = "okay"; };
+&vop {
status = "okay";assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;+};
+&vop_mmu {
status = "okay";+};
+&hdmi_in_vp0 {
status = "okay";+};
+&vp0_out_hdmi {
status = "okay";+};
You can accomplish the same thing already with:
&vp0_out_hdmi { remote-endpoint = <&hdmi_in_vp0>; };
My idea was to describe all possible connections in the dtsi file and let the board dts writer only en/disable the needed connections. When the connections are specified in the dts file then writing it is more difficult and error prone.
or:
&vp0_out_hdmi { /delete-property/ remote-endpoint; };
With this I have to change all connections that I don't need. With status = "okay" I have to change all connections that I actually do need, which will be much easier to read and write.
I'll stick to the status = "okay" method for the next round, maybe I can still convince you ;)
If it's the 'status' property you don't like being used when it's not a device that is enabled/disabled, then every other name would be fine with me as well.
Sascha