Re: [PATCH v3 2/3] drm/bridge: parade-ps8640: Use regmap APIs

Quoting Philip Chen (2021-09-14 16:28:44)

diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c index e340af381e05..8d3e7a147170 100644 --- a/drivers/gpu/drm/bridge/parade-ps8640.c +++ b/drivers/gpu/drm/bridge/parade-ps8640.c @@ -368,6 +396,12 @@ static int ps8640_probe(struct i2c_client *client)

    ps_bridge->page[PAGE0_DP_CNTL] = client;

•   ps_bridge->regmap[PAGE0_DP_CNTL] = devm_regmap_init_i2c(client, ps8640_regmap_config);
  

•   if (IS_ERR(ps_bridge->regmap[PAGE0_DP_CNTL])) {
  

•           return dev_err_probe(dev, PTR_ERR(ps_bridge->regmap[PAGE0_DP_CNTL]),
  

•                                "Error initting page 0 regmap\n");
  

This one also doesn't return -EPROBE_DEFER? The dev_err_probe() should really only be used on "get" style APIs that can defer.

•   }
  

•   for (i = 1; i < ARRAY_SIZE(ps_bridge->page); i++) {
            ps_bridge->page[i] = devm_i2c_new_dummy_device(&client->dev,
                                                         client->adapter,