Re: [PATCH v3 4/4] drm/i915/ttm: ensure we unmap when purging

On 1/6/22 18:49, Matthew Auld wrote:

Purging can happen during swapping out, or directly invoked with the madvise ioctl. In such cases this doesn't involve a ttm move, which skips umapping the object.

v2(Thomas):

• add ttm_truncate helper, and just call into i915_ttm_move_notify() to handle the unmapping step

Fixes: cf3e3e86d779 ("drm/i915: Use ttm mmap handling for ttm bo's.")

Should this Fixes: tag be when we we introduce truncate for the TTM backend. IIRC that was in a later commit?

Otherwise

Reviewed-by: Thomas Hellström thomas.hellstrom@linux.intel.com

/Thomas