Re: [PATCH v7 4/8] drm/sunxi: Add DT bindings documentation of Allwinner HDMI

On Tue, 29 Nov 2016 20:46:22 +0200 Laurent Pinchart laurent.pinchart@ideasonboard.com wrote: [snip]

...

+Example:

• hdmi: hdmi@01ee0000 {

• compatible = "allwinner,sun8i-a83t-hdmi";
  

• reg = <0x01ee0000 0x20000>;
  

• clocks = <&ccu CLK_BUS_HDMI>, <&ccu CLK_HDMI>,
  

• 	 <&ccu CLK_HDMI_DDC>;
  

• clock-names = "bus", "clock", "ddc-clock";
  

• resets = <&ccu RST_HDMI0>, <&ccu RST_HDMI1>;
  

• reset-names = "hdmi0", "hdmi1";
  

• pinctrl-names = "default";
  

• pinctrl-0 = <&hdmi_pins_a>;
  

• status = "disabled";
  

• #address-cells = <1>;
  

• #size-cells = <0>;
  

• port@0 {			/* video */
  

• 	reg = <0>;
  

• 	hdmi_tcon1: endpoint {
  

• 		remote-endpoint = <&tcon1_hdmi>;
  

• 	};
  

• };
  

• port@1 {			/* audio */
  

• 	reg = <1>;
  

• 	hdmi_i2s2: endpoint {
  

• 		remote-endpoint = <&i2s2_hdmi>;
  

• 	};
  

• };
  

You need a third port for the HDMI encoder output, connected to an HDMI connector DT node.

I don't see what you mean. The HDMI device is both the encoder and connector (as the TDA998x):

plane -> DE2 mixer ---> TCON -----> HDMI -----> display device ----- plane ------ - CRTC - - encoder \ connector -- (HDMI cable) audio-controller - - audio-codec /

...

• };