Re: [PATCH v4 02/14] vfio/mbochs: Fix missing error unwind of mbochs_used_mbytes

On Thu, Aug 05 2021, Jason Gunthorpe jgg@nvidia.com wrote:

Convert mbochs to use an atomic scheme for this like mtty was changed into. The atomic fixes various race conditions with probing. Add the missing error unwind. Also add the missing kfree of mdev_state->pages.

Fixes: 681c1615f891 ("vfio/mbochs: Convert to use vfio_register_group_dev()") Reported-by: Cornelia Huck cohuck@redhat.com Co-developed-by: Alex Williamson alex.williamson@redhat.com Reviewed-by: Christoph Hellwig hch@lst.de Signed-off-by: Jason Gunthorpe jgg@nvidia.com

---

samples/vfio-mdev/mbochs.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-)

Reviewed-by: Cornelia Huck cohuck@redhat.com