On 10/25/2013 02:35 PM, Igor Gnatenko wrote:
Aaron, add this notebook to list. I've CC'ed owner. And I've tested this patch on my TP X230 (add as Reported-and-Tested me please)
- {
.callback = video_set_use_native_backlight,.ident = "Dell Inspiron 7520",.matches = {DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"),},- },
Thanks Igor, updated patch follows:
From: Aaron Lu aaron.lu@intel.com Subject: [PATCH] ACPI / video: Add systems that should favour native backlight interface
Some system's ACPI video backlight control interface is broken and the native backlight control interface should be used by default. This patch sets the use_native_backlight parameter to true for those systems so that video backlight control interface will not be created. To be specific, the ThinkPad T430s/X230, Lenovo Yoga 13 and Dell Inspiron 7520 are added here.
Thinkpad T430s: Reported-by: Theodore Tso tytso@mit.edu Reported-and-tested-by: Peter Weber bugs@ttyhoney.com Thinkpad X230: Reported-and-tested-by: Igor Gnatenko i.gnatenko.brain@gmail.com Lenovo Yoga 13: Reported-by: Lennart Poettering lennart@poettering.net Reported-and-tested-by: Kevin Smith thirdwiggin@gmail.com Dell Inspiron 7520: Reported-by: Renat Ibragimov ibragimovrinat@mail.ru
Reference: https://bugzilla.kernel.org/show_bug.cgi?id=51231 Signed-off-by: Aaron Lu aaron.lu@intel.com --- drivers/acpi/video.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+)
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index d020df5..0a1b030 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -412,6 +412,12 @@ static int video_ignore_initial_backlight(const struct dmi_system_id *d) return 0; }
+static int __init video_set_use_native_backlight(const struct dmi_system_id *d) +{ + use_native_backlight = true; + return 0; +} + static struct dmi_system_id video_dmi_table[] __initdata = { /* * Broken _BQC workaround http://bugzilla.kernel.org/show_bug.cgi?id=13121 @@ -504,6 +510,38 @@ static struct dmi_system_id video_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion m4 Notebook PC"), }, }, + { + .callback = video_set_use_native_backlight, + .ident = "ThinkPad T430s", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430s"), + }, + }, + { + .callback = video_set_use_native_backlight, + .ident = "ThinkPad X230", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad X230"), + }, + }, + { + .callback = video_set_use_native_backlight, + .ident = "Lenovo Yoga 13", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo IdeaPad Yoga 13"), + }, + }, + { + .callback = video_set_use_native_backlight, + .ident = "Dell Inspiron 7520", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_VERSION, "Inspiron 7520"), + }, + }, {} };